Change in ovirt-engine[master]: core: Fix NPE when removing a VM with Cinder disks.

derez at redhat.com derez at redhat.com
Sun Jun 14 17:19:18 UTC 2015


Daniel Erez has submitted this change and it was merged.

Change subject: core: Fix NPE when removing a VM with Cinder disks.
......................................................................


core: Fix NPE when removing a VM with Cinder disks.

Remove disk from snapshot's OVF only if the snapshot exists.
Change the parameter class passed to coco to be
RemoveCinderDiskParameters.

Change-Id: I570f59bac7e1bc569d82767b8c6fee0b0d997ccb
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmCinderDisksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommand.java
2 files changed, 10 insertions(+), 6 deletions(-)

Approvals:
  Daniel Erez: Looks good to me, approved
  Jenkins CI: Looks good to me, but someone else must approve
  Maor Lipchuk: Verified



-- 
To view, visit https://gerrit.ovirt.org/42333
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I570f59bac7e1bc569d82767b8c6fee0b0d997ccb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list