Change in ovirt-engine[master]: engine: Quota API engine fixups

dfediuck at redhat.com dfediuck at redhat.com
Mon Jun 15 17:22:15 UTC 2015


Doron Fediuck has submitted this change and it was merged.

Change subject: engine: Quota API engine fixups
......................................................................


engine: Quota API engine fixups

Since quota was added only via UI till now, some bugs were
masked and now smoked out:

- Set default values for quota grace and threshold (hard/soft
limits).
- Enable javax.validation annotations for Quata entity.
- Return quota UUID when creating quota (setActionReturnValue).
- Fix Error message.
- Fix UI's NPEs incase only memory/cpu is defined

Change-Id: I51a7e9430c7c494a1608578e1f50e27c0e8a79ad
Signed-off-by: Gilad Chaplik <gchaplik at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddQuotaCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateQuotaCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddQuotaCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/QuotaCRUDParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabQuotaView.java
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
11 files changed, 64 insertions(+), 9 deletions(-)

Approvals:
  Doron Fediuck: Looks good to me, approved
  Gilad Chaplik: Verified



-- 
To view, visit https://gerrit.ovirt.org/39903
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I51a7e9430c7c494a1608578e1f50e27c0e8a79ad
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ori Liel <oliel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list