Change in ovirt-engine[master]: core: SPICE copyPaste/fileTransfer not passed properly

tjelinek at redhat.com tjelinek at redhat.com
Tue Jun 16 14:14:32 UTC 2015


Tomas Jelinek has submitted this change and it was merged.

Change subject: core: SPICE copyPaste/fileTransfer not passed properly
......................................................................


core: SPICE copyPaste/fileTransfer not passed properly

The problem was that the VmInfoBuilderBase checked if the SPICE device is there
according to the graphicsInfo.
The problem was that the graphicsInfo is a dynamic attribute containing things
like IP, port etc which exists only after the VM has been created - here we are
just creating it so it does not yet exist.

Fixed by creating this information in the RunVm and RunVmOnce commands
according to the DB value/parameters passed

Change-Id: Ic09709b579fd3e2fe622790f66286537ad01e728
Bug-Url: https://bugzilla.redhat.com/983019
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java
2 files changed, 23 insertions(+), 20 deletions(-)

Approvals:
  Tomas Jelinek: Verified
  Jenkins CI: Verified; Looks good to me, but someone else must approve
  Omer Frenkel: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/42038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic09709b579fd3e2fe622790f66286537ad01e728
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list