Change in ovirt-engine[master]: webadmin: Role descriptions

awels at redhat.com awels at redhat.com
Fri Jun 19 14:33:57 UTC 2015


Alexander Wels has submitted this change and it was merged.

Change subject: webadmin: Role descriptions
......................................................................


webadmin: Role descriptions

- Due to ec00576171bf1f7a123eaa36046d989d43d1bf30 which cleaned up
  how the tree was created. However it started using the name instead
  of the description of the node to display, which was fine for the
  first two levels but the last level which had all the configurable
  items got broken. This patch uses the description to display the label
  in the tree.
- Cleaned up some of the code formatting to adhere to current standards.
- Fixed minor height issue which caused 2 scrollbars to appear.

Change-Id: Ie38f9482f686e83b9b3738fa96e33f9713d28087
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1199753
Signed-off-by: Alexander Wels <awels at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleNode.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.ui.xml
4 files changed, 53 insertions(+), 97 deletions(-)

Approvals:
  Alexander Wels: Verified
  Jenkins CI: Passed CI tests
  Greg Sheremeta: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/42517
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie38f9482f686e83b9b3738fa96e33f9713d28087
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list