Change in ovirt-engine[master]: core: TestingAffinityRulesEnforcementPerCluster

amureini at redhat.com amureini at redhat.com
Tue Jun 23 13:41:53 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: TestingAffinityRulesEnforcementPerCluster
......................................................................


core: TestingAffinityRulesEnforcementPerCluster

Previously, this test used an anonymous inner extension of
AffinityRulesEnforcementPerCluster that assigned mocks to its  DAOs in
the wakeup() method. This behavior caused a NullPointerException since
the DAOs were also used elsewhere.

This method extracts the anonymous class to a named inner class to allow
setting the DAOs in the constructor and use throughout the class' life.

Change-Id: I2b722fb78d1ec32652a0315e1fcc88ebd46ff8e1
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManagerTest.java
1 file changed, 10 insertions(+), 10 deletions(-)

Approvals:
  Allon Mureinik: Verified; Passed CI tests
  Roy Golan: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/42619
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2b722fb78d1ec32652a0315e1fcc88ebd46ff8e1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list