Change in ovirt-engine[master]: core: Source VM is deleted after failed cloning attempt

[ofrenkel at redhat.com]

Omer Frenkel has submitted this change and it was merged.

Change subject: core: Source VM is deleted after failed cloning attempt
......................................................................


core: Source VM is deleted after failed cloning attempt

The root cause was that in the rollback flow the VM id has been inited from the
getParameters().getVmId() which points to the old VM.
Than, in AddVmCommand.removeVmRelatedEntitiesFromDb() the removeVmStatic() used
it to delete the VM - but since it pointed to the old VM it has been deleted.

Fixed by making sure that the VM ID always points to the new VM.

Change-Id: Ia44f6394914f956013c81ffef2dbcbfb120ec301
Bug-Url: https://bugzilla.redhat.com/1235179
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Tomas Jelinek: Verified
  Jenkins CI: Passed CI tests
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/42911
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia44f6394914f956013c81ffef2dbcbfb120ec301
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org