Change in ovirt-engine[master]: core: reduce coupling between VmAnalyzer and VdsManager
ahadas at redhat.com
ahadas at redhat.com
Mon Jun 29 14:57:21 UTC 2015
Arik Hadas has submitted this change and it was merged.
Change subject: core: reduce coupling between VmAnalyzer and VdsManager
......................................................................
core: reduce coupling between VmAnalyzer and VdsManager
VmAnalyzer was used to ask VdsManager if we are in a refresh iteration
to determine if VM statistics should be updated or not. This patch
changes that with a flag that is now being passed to VmsMonitoring that
specifies whether VM statistics should be updated or not, and VmAnalyzer
now check this flag instead.
Change-Id: I12a3608c5d8d6bce8c3ffe8b015ac81b57509780
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/PollVMStatsRefresher.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsMonitoring.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EventVMStatsRefresher.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmsMonitoringTest.java
5 files changed, 25 insertions(+), 7 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/42953
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I12a3608c5d8d6bce8c3ffe8b015ac81b57509780
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
More information about the Engine-commits
mailing list