Change in ovirt-engine[master]: getVMList: introducing onlyUUID parameter

oourfali at redhat.com oourfali at redhat.com
Mon Mar 9 11:23:12 UTC 2015


Oved Ourfali has submitted this change and it was merged.

Change subject: getVMList: introducing onlyUUID parameter
......................................................................


getVMList: introducing onlyUUID parameter

Due to vdsm sending only an array of vmids in a response to getVMList
the engine asks separately using VM.getStats which creates unnecessary
load. We need to make sure that for newer engines vdsm sends map of
vmids and status and for older engines an array as it was before. In
order to achieve it we introduce new parameter 'onlyUUID' for getVMList
which is ignored by older vdsms and it makes sure that newer vdsms send
a map which fixes performance issue.

Change-Id: I51dea68e89a2c1685d16ba1921e1373eeb721860
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Bug-Url: https://bugzilla.redhat.com/1198248
Related-To: https://gerrit.ovirt.org/#/c/38449
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Verified
  Francesco Romani: Looks good to me, but someone else must approve
  Omer Frenkel: Looks good to me, but someone else must approve
  Oved Ourfali: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/38462
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I51dea68e89a2c1685d16ba1921e1373eeb721860
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list