Change in ovirt-engine[master]: core: frontend: Fix Permissions.id value on instance creattion

oourfali at redhat.com oourfali at redhat.com
Wed Mar 11 14:37:35 UTC 2015


Oved Ourfali has submitted this change and it was merged.

Change subject: core: frontend: Fix Permissions.id value on instance creattion
......................................................................


core: frontend: Fix Permissions.id value on instance creattion

1. Reverts setting Permissions.id to Guid.Empty introduced in patch
   I35aad0115394fde0bf30a27b3eb47c46496bd821.

2. It sets Permission.id to Guid.Empty in GWT code, because correct id
   is set in AddPermissionCommand

Change-Id: I9617cf0ca558730bce9bf9e3209f472859b42664
Bug-Url: https://bugzilla.redhat.com/1195119
Signed-off-by: Martin Perina <mperina at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Permissions.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/SystemPermissionListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaUserListModel.java
4 files changed, 25 insertions(+), 11 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, but someone else must approve
  Martin Peřina: Verified
  Oved Ourfali: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/38575
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9617cf0ca558730bce9bf9e3209f472859b42664
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list