Change in ovirt-engine[master]: webadmin: new role dialog

awels at redhat.com awels at redhat.com
Mon Mar 16 14:44:50 UTC 2015


Alexander Wels has submitted this change and it was merged.

Change subject: webadmin: new role dialog
......................................................................


webadmin: new role dialog

- The New Role dialog layout was being messed up by
  different locales if the text was too long. This patch
  rearranges the popup dialog to use patternfly grids
  for the layout and makes sure the text can grow
  sufficiently to accomodate the different locales

Change-Id: I5db8fdcc2901dcc1820588f813cb5744323fb820
Signed-off-by: Alexander Wels <awels at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.ui.xml
2 files changed, 45 insertions(+), 59 deletions(-)

Approvals:
  Alexander Wels: Verified
  Greg Sheremeta: Looks good to me, but someone else must approve
  Vojtech Szocs: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/37553
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5db8fdcc2901dcc1820588f813cb5744323fb820
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list