Change in ovirt-engine[master]: userportal, webadmin: refactor EventHandlingCell logic

awels at redhat.com awels at redhat.com
Tue Mar 17 12:52:09 UTC 2015


Alexander Wels has submitted this change and it was merged.

Change subject: userportal, webadmin: refactor EventHandlingCell logic
......................................................................


userportal, webadmin: refactor EventHandlingCell logic

(Patch 4aa of 12)

Introduced EventHandlingCellMixin and moved EventHandlingCell::handlesEvent()
implementations to there. Some of them were shared -- this avoids copying
and pasting code.

No functional changes -- just a refactor.

Change-Id: I0c242022965982723c0068d2df3db6472dba6394
Signed-off-by: Greg Sheremeta <gshereme at redhat.com>
---
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/EventHandlingCellMixin.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/ListModelListBoxCell.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractCheckboxColumn.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/EnabledDisabledCheckboxCell.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/EnabledDisabledRadioCell.java
5 files changed, 36 insertions(+), 24 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Greg Sheremeta: Verified



-- 
To view, visit https://gerrit.ovirt.org/38720
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0c242022965982723c0068d2df3db6472dba6394
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list