Change in ovirt-engine[master]: userportal, webadmin: convert InfoIcons to PatternFly tooltips

awels at redhat.com awels at redhat.com
Thu Mar 19 19:52:02 UTC 2015


Alexander Wels has submitted this change and it was merged.

Change subject: userportal, webadmin: convert InfoIcons to PatternFly tooltips
......................................................................


userportal, webadmin: convert InfoIcons to PatternFly tooltips

Converted InfoIcon to use PatternFly tooltips.

* Enforced italic HTML in InfoIcon, with an option to disable.

* Because some InfoIcons require  a longer length than 220px (usual
  tooltip width), added infrastructure for setting a custom width
  on a tooltip.

  * Note: this infrastructure required a custom copy of gwtbootstrap3's
    Tooltip class. I will submit a patch to gwtbootstrap3 to incorporate
    this behavior. When that is released and we upgrade, the custom copy
    of Tooltip can be replaced. There is a TODO-GWT in the code for this.

Bug-Url: https://bugzilla.redhat.com/1067318
Bug-Url: https://bugzilla.redhat.com/1109816
Change-Id: Ie6a4cce6c708eacccc2733cd653b6ae135ad3d64
Signed-off-by: Greg Sheremeta <gshereme at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/WidgetWithInfo.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/InfoIcon.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/TooltipConfig.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tooltip/WidgetTooltip.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostConfigureLocalStoragePopupView.java
7 files changed, 60 insertions(+), 23 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Greg Sheremeta: Verified



-- 
To view, visit https://gerrit.ovirt.org/37990
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6a4cce6c708eacccc2733cd653b6ae135ad3d64
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list