Change in ovirt-engine[master]: core: introduce CinderBroker

derez at redhat.com derez at redhat.com
Tue Mar 24 20:06:12 UTC 2015


Daniel Erez has submitted this change and it was merged.

Change subject: core: introduce CinderBroker
......................................................................


core: introduce CinderBroker

Introducing CinderBroker class which handles all invocations
of Cinder sdk actions (e.g. createVolume/deleteVolume/etc).
The CinderBroker adds VdcBllErrors.CINDER_ERROR to executeFailedMessages
in case of an OpenStackResponseException.
This generic error is part of VdsmErrors as it relates to errors that
may occur in the execute phase. The messages are sent in plain string
(as opposed to codes), hence, translation is not applicable.

Change-Id: If71305412188be95dc88bc0d8646958a3d3e6aef
Bug-Url: https://bugzilla.redhat.com/1185826
Signed-off-by: Daniel Erez <derez at redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/CinderBroker.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
6 files changed, 50 insertions(+), 0 deletions(-)

Approvals:
  Daniel Erez: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/39016
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If71305412188be95dc88bc0d8646958a3d3e6aef
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list