Change in ovirt-engine[master]: restapi: Add VM parameters to VmPool collection

ofrenkel at redhat.com ofrenkel at redhat.com
Sun Mar 29 14:17:05 UTC 2015


Omer Frenkel has submitted this change and it was merged.

Change subject: restapi: Add VM parameters to VmPool collection
......................................................................


restapi: Add VM parameters to VmPool collection

A majority of VM parameters that are available in the UI when adding VM Pool
were missing from REST API VmPool collection.

Added new <vm> subelement with all the VM fields into the <vmpool> element.
The values of these fields override the values of the corresponding template
parameters. The structure is:

<vm_pool>
 <size>50</size>
 ...
 <template id="xxx"/>
 <vm>
  <some_overriden_field_a>new value</some_overriden_field_a>
  <some_overriden_field_b>new value 2</some_overriden_field_b>
 </vm>
</vm_pool>

Description on oVirt Wiki:
http://www.ovirt.org/Features/Vm_Parameters_in_REST_API_for_Vm_Pools

Change-Id: I791791a99abdf258f42b3e06288567f1b6c0bbf4
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1195167
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendCollectionResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolsResource.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmPoolMapper.java
4 files changed, 29 insertions(+), 5 deletions(-)

Approvals:
  Juan Hernandez: Looks good to me, approved
  Shmuel Leib Melamud: Verified



-- 
To view, visit https://gerrit.ovirt.org/38755
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I791791a99abdf258f42b3e06288567f1b6c0bbf4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Ori Liel <oliel at redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list