Change in ovirt-engine[master]: webadmin: DataCenterStorageListModel update availability ref...

derez at redhat.com derez at redhat.com
Mon Mar 30 14:40:37 UTC 2015


Daniel Erez has submitted this change and it was merged.

Change subject: webadmin: DataCenterStorageListModel update availability refactor.
......................................................................


webadmin: DataCenterStorageListModel update availability refactor.

Currently every time a selected DC is changed, or whenever the
availability of storage domains of a DC should be updated in the
DC's storage tab, the program runs through all the domains all over
again for each boolean value it needs. (e.g. is there a master
domain, is there an ISO domain, etc...).

This patch replaces the multiple iterations into one. at the end
of the iteration all the boolean values will be set.

This is a better design for future boolean values to add in code
redundancy and clearness aspects.

Change-Id: I88abe054994257e2d3bd781d4d3b53aece75cd2c
Signed-off-by: Amit Aviram <aaviram at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterStorageListModel.java
1 file changed, 19 insertions(+), 27 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Daniel Erez: Looks good to me, approved
  Allon Mureinik: Looks good to me, but someone else must approve
  Amit Aviram: Verified



-- 
To view, visit https://gerrit.ovirt.org/38585
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I88abe054994257e2d3bd781d4d3b53aece75cd2c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list