Change in ovirt-engine[master]: engine: Avoid static access to ResourceManager from HostMoni...

masayag at redhat.com masayag at redhat.com
Tue May 19 19:11:18 UTC 2015


Moti Asayag has submitted this change and it was merged.

Change subject: engine: Avoid static access to ResourceManager from HostMonitoring
......................................................................


engine: Avoid static access to ResourceManager from HostMonitoring

This allow to mock the ResourceManager easily in tests
and avoids the use of deprecated functionality.

Change-Id: I38e3e08c5d502ce4139df2a2f7c46ff0d0503378
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/HostMonitoringTest.java
3 files changed, 11 insertions(+), 13 deletions(-)

Approvals:
  Moti Asayag: Verified
  Yair Zaslavsky: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/40937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I38e3e08c5d502ce4139df2a2f7c46ff0d0503378
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976 at gmail.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list