Change in ovirt-engine[master]: core: fix compensation for import and clone vm

masayag at redhat.com masayag at redhat.com
Thu May 21 12:20:49 UTC 2015


Moti Asayag has submitted this change and it was merged.

Change subject: core: fix compensation for import and clone vm
......................................................................


core: fix compensation for import and clone vm

If the initialization that is done in post-construct accessed the
command's parameters in a non-transactive command that uses
compensation, the compensation didn't work. The problem is that when
instantiate the command for compensation, the parameters are not passed,
so the initialization in the post-construct failed.

The solution is to do the initialization in post-construct only when the
parameters are set.

Change-Id: Ie0e6d4b67d09537dedd167937e8949e7875d40a2
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Martin Peřina: Looks good to me, but someone else must approve
  Jenkins CI: Looks good to me, but someone else must approve
  Moti Asayag: Looks good to me, approved
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/41213
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0e6d4b67d09537dedd167937e8949e7875d40a2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list