Change in ovirt-engine[master]: webadmin, userportal: Optimize syntax checker handling

[vszocs at redhat.com]

Vojtech Szocs has submitted this change and it was merged.

Change subject: webadmin,userportal: Optimize syntax checker handling
......................................................................


webadmin,userportal: Optimize syntax checker handling

1. access to (search) syntax checker instance is now provided
   through Configurator#getSyntaxChecker

   * UserPortalConfigurator#getSyntaxChecker returns null
     (not available in UserPortal context)

   * WebAdminConfigurator#getSyntaxChecker returns instance
     obtained via SyntaxCheckerFactory

2. removed SearchableListModel#syntaxChecker field along
   with related code (instance initialization, getter)

3. modified SearchableListModel#isSearchValidForServerSideSorting
   to access syntax checker through Configurator

   * in UserPortal context, syntax checker will be null
     and above method will simply return true

   * in WebAdmin context, syntax checker will be non-null
     and existing behavior will be retained

4. modified SearchSuggestModel to access syntax checker
   through Configurator

5. removed unused SyntaxCheckerFactory#getUISyntaxChecker

This patch improves performance of UserPortal while keeping
existing behavior of WebAdmin (where syntax checker is used
in SearchableListModel#isSearchValidForServerSideSorting).

Change-Id: Iab7f369fa26452fe49c57f99dc53919a2bad0412
Bug-Url: https://bugzilla.redhat.com/1221236
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactory.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SearchableListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java
7 files changed, 31 insertions(+), 23 deletions(-)

Approvals:
  Tomas Jelinek: Looks good to me, approved
  Jenkins CI: Looks good to me, but someone else must approve
  Greg Sheremeta: Looks good to me, approved
  Vojtech Szocs: Verified



-- 
To view, visit https://gerrit.ovirt.org/41237
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iab7f369fa26452fe49c57f99dc53919a2bad0412
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org