Change in ovirt-engine[master]: userportal, webadmin: fix broken helptag implementation

[gshereme at redhat.com]

Greg Sheremeta has submitted this change and it was merged.

Change subject: userportal, webadmin: fix broken helptag implementation
......................................................................


userportal, webadmin: fix broken helptag implementation

Helptags were reusing some of the hashname infrastructure. This
was 1. messy, 2. caused a bug where the help icon would not render
unless the helptag == hashname. Cleaned this up and fixed the bug.

Change-Id: Id244c5d068c6146da92287536bf919da1d5aee3c
Bug-Url: https://bugzilla.redhat.com/1176581
Bug-Url: https://bugzilla.redhat.com/1176583
Bug-Url: https://bugzilla.redhat.com/1223529
Signed-off-by: Greg Sheremeta <gshereme at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java
2 files changed, 15 insertions(+), 12 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Jenkins CI: Looks good to me, but someone else must approve
  Greg Sheremeta: Verified
  Vojtech Szocs: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/41238
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id244c5d068c6146da92287536bf919da1d5aee3c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org