Change in ovirt-engine[master]: core: Inject Task schedulers instead of JNDI lookups

rgolan at redhat.com rgolan at redhat.com
Thu May 28 07:50:08 UTC 2015


Roy Golan has submitted this change and it was merged.

Change subject: core: Inject Task schedulers instead of JNDI lookups
......................................................................


core: Inject Task schedulers instead of JNDI lookups

continue the JNDI and EJB cleanup and move Singleton like task
scheduling to CDI.


<code>
 @Inject
 SchedulUtilBaseImpl taskScheduler; // will inject a SchedulerUtilBaseImpl
</code>

- getInstance() exist for legacy code. Prefer Injection over it.
- all scheulers are loaded first after the DB connection established.
  See Backend.initialize()

Change-Id: I2288d0bd0584c7ba17f3dabaff268e40cbdddbea
Signed-off-by: Roy Golan <rgolan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RescheduleGlusterVolumeSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandExecutor.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java
M backend/manager/modules/scheduler/exclude-filters.xml
M backend/manager/modules/scheduler/pom.xml
M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/DBSchedulerUtilQuartzImpl.java
M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtil.java
M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilQuartzImpl.java
A backend/manager/modules/scheduler/src/main/resources/META-INF/beans.xml
M ear/pom.xml
12 files changed, 91 insertions(+), 89 deletions(-)

Approvals:
  Eli Mesika: Looks good to me, approved
  Jenkins CI: Verified; Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/41035
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2288d0bd0584c7ba17f3dabaff268e40cbdddbea
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzelkha at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list