Change in ovirt-engine[master]: restapi: Use matrix parameters to remove template disks

juan.hernandez at redhat.com juan.hernandez at redhat.com
Mon Nov 2 07:55:08 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: restapi: Use matrix parameters to remove template disks
......................................................................


restapi: Use matrix parameters to remove template disks

The operation that removes a template disk supports the "force" and
"storage_domain" parameters. In order to use it them the "DELETE" method
supports an optional action parameter:

  DELETE /templates/{template:id}/disks/{disk:id}
  <action>
    <force>...</force>
    <storage_domain id="..."/>
  </action>

This patch remplaces this optional action parameter with the optional
matrix parameters "force" and "storage_domain", so the way to remove a
template disk is now the following:

  DELETE /templates/{template:id}/disks/{disk:id};force=true

  DELETE /templates/{template:id}/disks/{disk:id};storage_domain=123

Change-Id: I7d527dcec4c819e70eea28339b2eab47894e8db7
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/restapi/README.md
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/TemplateDiskResource.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResourceTest.java
5 files changed, 67 insertions(+), 44 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/47891
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7d527dcec4c819e70eea28339b2eab47894e8db7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list