Change in ovirt-engine[master]: restapi: Use POST instead of DELETE to remove multiple bricks

juan.hernandez at redhat.com juan.hernandez at redhat.com
Mon Nov 2 07:58:07 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: restapi: Use POST instead of DELETE to remove multiple bricks
......................................................................


restapi: Use POST instead of DELETE to remove multiple bricks

The operation that removes multiple Gluster bricks was implemented using
the "DELETE" method and passing the list of bricks as the body of the
request:

  DELETE /clusters/{cluster:id}/glustervolumes/{volume:id}/bricks
  <bricks>
    <bricks id="..."/>
    <bricks id="..."/>
    ...
  </bricks>

This is problematic because the "DELETE" method shouldn't have a body,
so it has been replaced with a new "remove" action that uses the "POST"
method:

  POST /clusters/{cluster:id}/glustervolumes/{volume:id}/bricks/remove
  <bricks>
    <bricks id="..."/>
    <bricks id="..."/>
    ...
  </bricks>

Change-Id: I6743e19222142e2fb699265c8ba400e2935bae3a
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/restapi/README.md
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterBricksResource.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResourceTest.java
7 files changed, 46 insertions(+), 16 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/47901
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6743e19222142e2fb699265c8ba400e2935bae3a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list