Change in ovirt-engine[master]: core: avoid NPE on add template when balloonEnabled is null

masayag at redhat.com masayag at redhat.com
Wed Nov 4 04:57:26 UTC 2015


Moti Asayag has submitted this change and it was merged.

Change subject: core: avoid NPE on add template when balloonEnabled is null
......................................................................


core: avoid NPE on add template when balloonEnabled is null

When importing an image as template from Glance,
'balloonEnabled' is null. Consequently, an NPE
is thrown on VmDeviceUtils -> copyVmDevices.

Since 'balloonEnabled' been defaulted to null on
I16adef671bc77e26f56657add59621a1aa9b1c4a,
fixed by comparing to TRUE.

Change-Id: Ie54212974b8deea6141d0a1b07dca393565e1dc0
Bug-Url: https://bugzilla.redhat.com/1275629
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Daniel Erez: Verified
  Arik Hadas: Looks good to me, but someone else must approve
  Oved Ourfali: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/48036
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie54212974b8deea6141d0a1b07dca393565e1dc0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list