Change in ovirt-engine[master]: engine: Common changes for Bonding modes 0, 5 and 6 should b...

alkaplan at redhat.com alkaplan at redhat.com
Thu Nov 5 11:57:28 UTC 2015


Alona Kaplan has submitted this change and it was merged.

Change subject: engine: Common changes for Bonding modes 0, 5 and 6 should be avoided for VM networks
......................................................................


engine: Common changes for Bonding modes 0, 5 and 6 should be avoided for VM networks

Extracting hardcoded strings and values for bond modes.
To be used in patches 46560 and 46251

Change-Id: Id5353a23ace44eef8ce6fd373b239a0d485d831d
Bug-Url: https://bugzilla.redhat.com/1094842
Signed-off-by: Marcin Mirecki <mmirecki at redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/BondMode.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
3 files changed, 79 insertions(+), 14 deletions(-)

Approvals:
  Marcin Mirecki: Verified
  Martin Mucha: Looks good to me, but someone else must approve
  Alona Kaplan: Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/46797
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id5353a23ace44eef8ce6fd373b239a0d485d831d
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list