Change in ovirt-engine[ovirt-engine-3.6]: frontend: default volume format selection in new template wi...

tnisan at redhat.com tnisan at redhat.com
Thu Nov 5 18:36:42 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: frontend: default volume format selection in new template window
......................................................................


frontend: default volume format selection in new template window

When making a template from a vm via the ui, one can choose the volume
format of each template disk (92665e0af829d25273d5d45669847569eae6f5cc).
Before this feature, the format of each disk was the same as its base
snapshot, but now it's set to QCOW2 by default.
This patch restores the old behavior such that the format is chosen to
be the same as the base snapshot's format by default.

Change-Id: I364a8f23f75b583c1f5b24051d374f32fa53a39d
Bug-Url: https://bugzilla.redhat.com/1257240
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAncestorImagesByImagesIdsQuery.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAncestorImagesByImagesIdsQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDaoImpl.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java
M packaging/dbscripts/disk_images_sp.sql
9 files changed, 193 insertions(+), 4 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved; Passed CI tests
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/48105
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I364a8f23f75b583c1f5b24051d374f32fa53a39d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list