Change in ovirt-engine[ovirt-engine-3.6]: core: Audit log on remove disk should be on failure.

tnisan at redhat.com tnisan at redhat.com
Sun Nov 8 12:17:54 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: core: Audit log on remove disk should be on failure.
......................................................................


core: Audit log on remove disk should be on failure.

On remove disk failure, an audit log should still be performed
regardless to the flag shouldBeLogged.

Also, when removing a VM with Cinder disks set the log flag to false, since
the remove of the VM should already log this action.

Change-Id: I831f7bb78ce53586ce4eca1edd61540345536218
Bug-Url: https://bugzilla.redhat.com/1278126
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmCinderDisksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveCinderDiskCommand.java
2 files changed, 3 insertions(+), 4 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Daniel Erez: Looks good to me, approved
  Maor Lipchuk: Verified



-- 
To view, visit https://gerrit.ovirt.org/48236
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I831f7bb78ce53586ce4eca1edd61540345536218
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list