Change in ovirt-engine[master]: backend: use Collections.singletonList instead of Arrays.asList

amureini at redhat.com amureini at redhat.com
Tue Nov 10 13:03:26 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: backend: use Collections.singletonList instead of Arrays.asList
......................................................................


backend: use Collections.singletonList instead of Arrays.asList

When building a list with one node only and with no requirement for
adding or removing nodes from the list, it's better to use
Collections.singletonList for performance reasons.

Change-Id: I0cab98ea362d708712716e956e437e1eeff83d4d
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Allon Mureinik: Looks good to me, approved; Passed CI tests
  Freddy Rolland: Looks good to me, but someone else must approve
  Idan Shaby: Verified



-- 
To view, visit https://gerrit.ovirt.org/48326
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0cab98ea362d708712716e956e437e1eeff83d4d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list