Change in ovirt-engine[master]: core: Change enum JSON deserialization

masayag at redhat.com masayag at redhat.com
Tue Nov 10 14:33:15 UTC 2015


Moti Asayag has submitted this change and it was merged.

Change subject: core: Change enum JSON deserialization
......................................................................


core: Change enum JSON deserialization

This patch introduces an enum deserializer to replace the behavior
that in case of an unnown literal an exception would be thrown.
This may happen in the future, if a Command parameter class with an enum
field is stored in DB, and then oVirt engine is upgraded, and the new code
contains a change in the enum literal.

Change-Id: Ie9d6f2e4a02eeda999e525101c2f54789a34cfaf
Signed-off-by: Yair Zaslavsky <yzaslavs at redhat.com>
---
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonEnumDeserializer.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializer.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializerFactory.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializerProvider.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectDeserializerTest.java
5 files changed, 108 insertions(+), 0 deletions(-)

Approvals:
  Ravi Nori: Verified
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/17951
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie9d6f2e4a02eeda999e525101c2f54789a34cfaf
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <wallaroo1976 at gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list