Change in ovirt-engine[master]: backend: save call to db if not needed in CreateImageTemplat...

tnisan at redhat.com tnisan at redhat.com
Thu Nov 12 08:02:37 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: backend: save call to db if not needed in CreateImageTemplateCommand
......................................................................


backend: save call to db if not needed in CreateImageTemplateCommand

In CreateImageTemplateCommand.executeCommand we first call to
fillVolumeInformation (a db call), and then in some cases we override
the information we got from this db call.
In this patch we first check if we need the information, and only if we
do - we call fillVolumeInformation.

Change-Id: I590b3bada2446f48e8bcda2f15c63a69b2016eca
Signed-off-by: Idan Shaby <ishaby at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Idan Shaby: Verified
  Arik Hadas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/47826
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I590b3bada2446f48e8bcda2f15c63a69b2016eca
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list