Change in ovirt-engine[master]: core: detaching master domain cleanup

[amureini at redhat.com]

Allon Mureinik has submitted this change and it was merged.

Change subject: core: detaching master domain cleanup
......................................................................


core: detaching master domain cleanup

The LinqUtils call in
StorageDomainCommandBase#isDetachAllowed(boolean) is useless - it
retrieves a domain from the pool that has the same ID of the domain
being removed (i.e., the exact same domain) and an "Active" status.
The previous call to checkStorageDomainStatus in canDetachDomain
ensures its status will be "Maintenance" or "Inactive", so it's known
to return an null.

Since its result is known, it can be skipped, and save a relatively
expensive database call.

Change-Id: Iff87f89170d555d98ec071b42e46f3dff1883b1b
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
1 file changed, 3 insertions(+), 19 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/48155
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iff87f89170d555d98ec071b42e46f3dff1883b1b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>