Change in ovirt-engine[master]: core: StorageHandlingCommandBase master SD query

amureini at redhat.com amureini at redhat.com
Mon Nov 16 17:07:31 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: StorageHandlingCommandBase master SD query
......................................................................


core: StorageHandlingCommandBase master SD query

Retrieve the master domain with the appropriate DAO methods instead of
querying all the domains in the pool and iterating them in-memory.

This patch improves both the code's readability and its performance,
especially in large-scale pools that contain many domains.

Change-Id: I92a8a8fe7563e8ae21b300db67a7f1aa4a86f34a
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java
1 file changed, 3 insertions(+), 11 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Ala Hino: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/48586
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I92a8a8fe7563e8ae21b300db67a7f1aa4a86f34a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list