Change in ovirt-engine[master]: core: Allow to remove Hosted Engine direct lun disks only

rgolan at redhat.com rgolan at redhat.com
Tue Nov 17 12:45:48 UTC 2015


Roy Golan has submitted this change and it was merged.

Change subject: core: Allow to remove Hosted Engine direct lun disks only
......................................................................


core: Allow to remove Hosted Engine direct lun disks only

In order to allow importing hosted engine disks we need to allow
removing them prior to the import. Still, removing any other type of
hosted engine disks is banned.

Change-Id: I3ed3d964921fa051c94383b0676f83618439db50
Bug-Url: https://bugzilla.redhat.com/1273378
Signed-off-by: Roy Golan <rgolan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveDiskCommandTest.java
3 files changed, 80 insertions(+), 18 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Roy Golan: Verified
  Maor Lipchuk: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/47706
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3ed3d964921fa051c94383b0676f83618439db50
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list