Change in ovirt-engine[master]: core: StorageServerConnectionLunMapDaoTest members

amureini at redhat.com amureini at redhat.com
Wed Nov 25 16:51:53 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: StorageServerConnectionLunMapDaoTest members
......................................................................


core: StorageServerConnectionLunMapDaoTest members

Reduce members' scope and convert them to local variables, or better
yet, remove them completely where possible.

This change makes the class easier to read and understand by removing
what is essentially transient data from the test's state so these
members don't steal the reader's focus.

Change-Id: I01a6a96c6b09cec87447086af908820e3363e41f
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionLunMapDaoTest.java
1 file changed, 2 insertions(+), 10 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/49064
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I01a6a96c6b09cec87447086af908820e3363e41f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list