Change in ovirt-engine[master]: core: AddVdsSpmIdCommand streaming API

amureini at redhat.com amureini at redhat.com
Wed Nov 25 16:51:54 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: AddVdsSpmIdCommand streaming API
......................................................................


core: AddVdsSpmIdCommand streaming API

Replaced the outdated LinqUtils call with a more modern use of Java
8's stream APIs.

Besides cleaning up the code, it offers a slight performance
improvement by iterating the list only once instead of twice - one for
extracting the spm_vds_ids and another one for sorting it.

Change-Id: I23080c2241ee8470b5eeae44e70097ce555d23f1
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java
1 file changed, 4 insertions(+), 9 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified; Passed CI tests
  Ala Hino: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/49042
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I23080c2241ee8470b5eeae44e70097ce555d23f1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list