Change in ovirt-engine[master]: core: Fix unintentional integer overflow

masayag at redhat.com masayag at redhat.com
Thu Nov 26 09:05:24 UTC 2015


Moti Asayag has submitted this change and it was merged.

Change subject: core: Fix unintentional integer overflow
......................................................................


core: Fix unintentional integer overflow

Fixes possible integer overflow before saving value into long field.
This was caused by type change int -> long in ThreadUtils.sleep() in
patch I870c2b37ba7c818fca113dfafdf12bd5083db92b. Issues were detected in
Coverity CIDs 1338744 and 1338745.

Change-Id: Id7f1386efec4267c78914e36bf7e0e773669959f
Signed-off-by: Martin Perina <mperina at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/SshSoftFencingCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/VdsKdumpDetectionCommand.java
4 files changed, 11 insertions(+), 5 deletions(-)

Approvals:
  Martin Peřina: Verified
  Jenkins CI: Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/49162
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id7f1386efec4267c78914e36bf7e0e773669959f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list