Change in ovirt-engine[master]: core: Remove unnecessary null check for VdcReturnValueBase i...

masayag at redhat.com masayag at redhat.com
Fri Nov 27 11:52:07 UTC 2015


Moti Asayag has submitted this change and it was merged.

Change subject: core: Remove unnecessary null check for VdcReturnValueBase instance
......................................................................


core: Remove unnecessary null check for VdcReturnValueBase instance

VdcReturnValueBase is created as a result of command execution and it
should never be null (otherwise there is a bug in command
infrastructure). This problematic null check was reported by Coverity
CIDs 1340335-1340338.

Change-Id: I9d77115081e5d9ec7e6714f60c22f717d2da2b3b
Signed-off-by: Martin Perina <mperina at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/RegisterVdsQuery.java
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Martin Peřina: Verified
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/49292
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9d77115081e5d9ec7e6714f60c22f717d2da2b3b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>



More information about the Engine-commits mailing list