Change in ovirt-engine[ovirt-engine-3.6]: core: Surround vds command with try catch.

tnisan at redhat.com tnisan at redhat.com
Tue Oct 6 16:16:16 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: core: Surround vds command with try catch.
......................................................................


core: Surround vds command with try catch.

Avoid NPE when calling a query which fails on executing a VDS
connect/disconnect command.
The proposed fix is to surround the query calls of the VDS commands
with try/catch, so the query will not fail and return Null as a result.

Change-Id: Ife176c6db31382053d6f96747b1bc6011a630582
Bug-Url: https://bugzilla.redhat.com/1263695
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsWithAttachedStoragePoolGuidQuery.java
1 file changed, 16 insertions(+), 6 deletions(-)

Approvals:
  Tal Nisan: Passed CI tests
  Daniel Erez: Looks good to me, approved
  Maor Lipchuk: Verified

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/47034
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ife176c6db31382053d6f96747b1bc6011a630582
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list