Change in ovirt-engine[master]: db: executed config cleanup as upgrade script

[emesika at redhat.com]

Eli Mesika has submitted this change and it was merged.

Change subject: db: executed config cleanup as upgrade script
......................................................................


db: executed config cleanup as upgrade script

Up to now when a config entry was deprecated, we had to remove it in the
pre-upgrade step calling fn_db_delete_config_value from 0000_config.sql.

This may be problematic if a reference to the deleted entry exists in one
of the upgrade scripts, in such case the entry will be removed in the
pre-upgrade step and then the upgrade script referring this key will fail
and cause all the upgrade process to fail.

This patch moves all deprecated config entries to an upgrade script
resolving this issue and adds additional benefit of executing all this
mass removals only once instead doing that again and again on each
upgrade.

>From now on, please delete deprecated config entries in a regular
upgrade script.

Change-Id: I062b6c9df0f812e3e36cdfed36854dddb045c62d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1269796
Signed-off-by: emesika <emesika at redhat.com>
---
A packaging/dbscripts/upgrade/03_06_1880_delete_deprecated_config_values.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
2 files changed, 177 insertions(+), 174 deletions(-)

Approvals:
  Martin Peřina: Looks good to me, but someone else must approve
  Eli Mesika: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/47033
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I062b6c9df0f812e3e36cdfed36854dddb045c62d
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: automation at ovirt.org