Change in ovirt-engine[master]: core: Logging null check

oourfali at redhat.com oourfali at redhat.com
Wed Oct 14 13:41:25 UTC 2015


Oved Ourfali has submitted this change and it was merged.

Change subject: core: Logging null check
......................................................................


core: Logging null check

value may very well be null. If this happens AND an exception is thrown,
the logging statement will fail when attempting to call
value.getClass().getName().

This fix safe-guards against this condition and just log "null" in such
a situation.

This patch fixed Coverity issue #1088577.

Change-Id: I9d520a01fb3950193d8c93293c09fc7ee7d51e85
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/BatchProcedureExecutionConnectionCallback.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified
  Oved Ourfali: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/47272
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9d520a01fb3950193d8c93293c09fc7ee7d51e85
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list