Change in ovirt-engine[master]: engine: PersistentSetupNetworks audit log fix

alkaplan at redhat.com alkaplan at redhat.com
Thu Oct 22 12:07:45 UTC 2015


Alona Kaplan has submitted this change and it was merged.

Change subject: engine: PersistentSetupNetworks audit log fix
......................................................................


engine: PersistentSetupNetworks audit log fix

The audit log should display the networks names only if they were passed
to it as parameters.
It shouldn't try to calculate the names of the changed networks. It causes
bugs and doesn't have a big added value.

Change-Id: Ib6fee08f46f5b79e78f94fda1b3f4440898f5a2e
Bug-Url: https://bugzilla.redhat.com/1242236
Signed-off-by: Alona Kaplan <alkaplan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentHostSetupNetworksCommand.java
D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/function/NetworkNameFromNetworkAttachmentTransformationFunction.java
D backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/function/NetworkNameFromNetworkAttachmentTransformationFunctionTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
5 files changed, 11 insertions(+), 102 deletions(-)

Approvals:
  Martin Mucha: Looks good to me, but someone else must approve
  Alona Kaplan: Verified; Passed CI tests
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/47429
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6fee08f46f5b79e78f94fda1b3f4440898f5a2e
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Eliraz Levi <elevi at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list