Change in ovirt-engine[ovirt-engine-3.5]: core: hotfix daotests in VmStaticDAOTest

tnisan at redhat.com tnisan at redhat.com
Tue Oct 27 11:46:50 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: core: hotfix daotests in VmStaticDAOTest
......................................................................


core: hotfix daotests in VmStaticDAOTest

testGetOrderedVmGuidsForRunMultipleActionsByMigrationSupport which
tested db
logic for ordered VmGuids retrieval (with respect to MigrationSupport
attribute) was failing because the number of tested vms was 4, but
MigrationSupport has only 3 possible values. Therefore there were 2 VMs
that
were equal with respect to this ordering.

Hot-fixed by restricting the number of test VMs to 3.

Change-Id: I53df7e6003582ece29387c59312ea9a267f7a1d0
Bug-Url: https://bugzilla.redhat.com/1220116
Signed-off-by: Frantisek Kobzik <fkobzik at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDAOTest.java
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Dudi Maroshi: Verified
  Jenkins CI: Passed CI tests
  Roy Golan: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/47405
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I53df7e6003582ece29387c59312ea9a267f7a1d0
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Dudi Maroshi <dudi at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>



More information about the Engine-commits mailing list