Change in ovirt-engine[master]: core: Fix RandomUtils#nextPropertyString

amureini at redhat.com amureini at redhat.com
Thu Sep 3 10:02:01 UTC 2015


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Fix RandomUtils#nextPropertyString
......................................................................


core: Fix RandomUtils#nextPropertyString

nextPropertyString was implemented incorrectly, with a misunderstanding
of how RandomStringUtils works, in a way that may have returned illegal
characters such as '[', ']' and ' '.
This patch fixes it so it really returns strings that only contain
alpha-numeric characters, underscores ('_') and periods ('.').

Change-Id: Ia98c6b78e3ca958779d413e06ced650f9740589d
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/RandomUtils.java
1 file changed, 18 insertions(+), 4 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/45675
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia98c6b78e3ca958779d413e06ced650f9740589d
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list