Change in ovirt-engine[ovirt-engine-3.6]: core: userprofile: handle guid != userid

tnisan at redhat.com tnisan at redhat.com
Thu Sep 10 11:12:05 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: core: userprofile: handle guid != userid
......................................................................


core: userprofile: handle guid != userid

frontend never fills the userId into UserProfileParameters,
relying on two facts:
- user is logged and implicit in every webadmin/userportal session
- that backend will always and only manipulate the profile of the
  current user, discarding any value is passed.

A future patch will add RESTAPI support for key manipulation,
and RESTAPI can transparently pass any guid, and backend must
explicitely return error if user is not allowed to make changes.

This patch enhances userprofile support to accomodate both frontend
and RESTAPI needs.

Change-Id: I0d1912d48f8b84e7108833331ce5d0620487213f
Bug-Url: https://bugzilla.redhat.com/1254445
Signed-off-by: Francesco Romani <fromani at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UserProfilesOperationCommandBase.java
1 file changed, 11 insertions(+), 0 deletions(-)

Approvals:
  Tal Nisan: Passed CI tests
  Francesco Romani: Verified
  Omer Frenkel: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/45971
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0d1912d48f8b84e7108833331ce5d0620487213f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list