Change in ovirt-engine[ovirt-engine-3.6]: webadmin: races in pool edit

tnisan at redhat.com tnisan at redhat.com
Thu Sep 10 12:13:17 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: races in pool edit
......................................................................


webadmin: races in pool edit

2 bugs:
1 if the pool was not based on the latest template the model was not properly
inited

2 initTemplate() was called in init - but it triggered (async) the
templateWithVersion_SelectedItemChanged and in parallel the clusters are
loaded. If the clusters were set up before the
templateWithVersion_SelectedItemChanged was called, it was ok. If the opposite
way around, NPE was thrown

Change-Id: I59dcd4b870b76ae849d4a5993adfc6202694e5e7
Bug-Url: https://bugzilla.redhat.com/1260917
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Tomas Jelinek: Verified
  Shahar Havivi: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/45937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I59dcd4b870b76ae849d4a5993adfc6202694e5e7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list