Change in ovirt-engine[ovirt-engine-3.6]: core: added proper watchdog CAD checks

tnisan at redhat.com tnisan at redhat.com
Sun Sep 20 12:37:27 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: core: added proper watchdog CAD checks
......................................................................


core: added proper watchdog CAD checks

The type and action was checked only on one place - added to generic validator
and used everywhere.

Change-Id: I36d8e0e16dd3259a177199eb6c90100f2cc77cf8
Bug-Url: https://bugzilla.redhat.com/1261015
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractVmWatchdogCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddWatchdogCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateWatchdogCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmWatchdogValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmWatchdogValidatorTest.java
9 files changed, 103 insertions(+), 48 deletions(-)

Approvals:
  Tomas Jelinek: Verified
  Jenkins CI: Passed CI tests
  Omer Frenkel: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/46345
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I36d8e0e16dd3259a177199eb6c90100f2cc77cf8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list