Change in ovirt-engine[ovirt-engine-3.6]: core: add missing audit log on migration failure

tnisan at redhat.com tnisan at redhat.com
Mon Sep 21 11:44:08 UTC 2015


Tal Nisan has submitted this change and it was merged.

Change subject: core: add missing audit log on migration failure
......................................................................


core: add missing audit log on migration failure

In the following scenario:
1. Migrate VM
2. VM fails to migrate to the first host
3. There are no other hosts to migrate to

Assuming the number of retries for a VM migration is not
set to 1, the audit log VM_MIGRATION_FAILED was not
generated but VM_MIGRATION_FAILED_NO_VDS_TO_RUN_ON was
generated instead.

This patch fixes it by changing the audit log
VM_MIGRATION_FAILED_NO_VDS_TO_RUN_ON to be a warning
that only specifies that no host was found and after it
VM_MIGRATION_FAILED is generated to summarize that the
migration failed.

Change-Id: I8aaa2004102269fed78eb737a0c1806821e711ef
Bug-Url: https://bugzilla.redhat.com/1193025
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
3 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Verified



-- 
To view, visit https://gerrit.ovirt.org/46421
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8aaa2004102269fed78eb737a0c1806821e711ef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list