Change in ovirt-engine[ovirt-engine-3.6]: core: REVERT&FIX of: core: Remove deprecated and unused VdcO...

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Tue Sep 22 13:01:40 UTC 2015


Piotr Kliczewski has submitted this change and it was merged.

Change subject: core: REVERT&FIX of: core: Remove deprecated and unused VdcOptions from db
......................................................................


core: REVERT&FIX of: core: Remove deprecated and unused VdcOptions from db

reverted-Change-Id: I51d7ce9359a9ad38a034d656fb4ac1c5bab2ff43

in given patch there's problem with applying upgrade scripts. In one
of upgrade scripts, values is read from vdc_options table and stored
elsewhere, rendering this vdc_options row useless. However, if we
remove this value from vdc_options table in 0000_config.sql, upgrade
script won't find it and won't persist it elsewhere. Therefore we need
to remove these values only after it's useless, ie. in upgrade script.

Bug-Url: https://bugzilla.redhat.com/1265136
Change-Id: Ic7f4593c55cfb65084d94a96e92f93ec6adcf010
Signed-off-by: Martin Mucha <mmucha at redhat.com>
---
A packaging/dbscripts/upgrade/03_06_1840_remove_deprecated_vdc_options.sql
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
2 files changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Piotr Kliczewski: Passed CI tests
  Martin Peřina: Looks good to me, but someone else must approve
  Martin Mucha: Verified
  Moti Asayag: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/46488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7f4593c55cfb65084d94a96e92f93ec6adcf010
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list