Change in ovirt-engine[master]: restapi: Remove useless object in "BackendGraphicsConsoleRes...
juan.hernandez at redhat.com
juan.hernandez at redhat.com
Wed Sep 23 14:26:40 UTC 2015
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Remove useless object in "BackendGraphicsConsoleResource"
......................................................................
restapi: Remove useless object in "BackendGraphicsConsoleResource"
This is needed in order to avoid the following findbugs warning:
Useless object created
Our analysis shows that this object is useless. It's created and
modified, but its value never go outside of the method or produce any
side-effect. Either there is a mistake and object was intended to be
used or it can be removed.
This analysis rarely produces false-positives. Common false-positive
cases include:
- This object used to implicitly throw some obscure exception.
- This object used as a stub to generalize the code.
- This object used to hold strong references to weak/soft-referenced
objects.
Bug kind and pattern: UC - UC_USELESS_OBJECT
Change-Id: I2a42dec0128c3d5a0178dc92e96b219cf284efef
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGraphicsConsoleResource.java
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46589
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a42dec0128c3d5a0178dc92e96b219cf284efef
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
More information about the Engine-commits
mailing list