Change in ovirt-engine[master]: restapi: Add missed features

juan.hernandez at redhat.com juan.hernandez at redhat.com
Wed Sep 23 14:27:14 UTC 2015


Juan Hernandez has submitted this change and it was merged.

Change subject: restapi: Add missed features
......................................................................


restapi: Add missed features

This is needed in order to avoid the following findbugs warning, and it
is a real bug as well:

  Useless non-empty void method

  Our analysis shows that this non-empty void method does not actually
  perform any useful work. Please check it: probably there's a mistake
  in its code or its body can be fully removed.

  We are trying to reduce the false positives as much as possible, but in
  some cases this warning might be wrong. Common false-positive cases
  include:

  - The method is intended to trigger loading of some class which may have
  a side effect.
  - The method is intended to implicitly throw some obscure exception.

  Bug kind and pattern: UC - UC_USELESS_VOID_METHOD

Change-Id: I28386f1cbee0298ec1142d5c63b6d732de67937a
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/46590
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I28386f1cbee0298ec1142d5c63b6d732de67937a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list