Change in ovirt-engine[master]: core: Use "parseXXX" in "BrandingTheme"
juan.hernandez at redhat.com
juan.hernandez at redhat.com
Thu Sep 24 10:24:26 UTC 2015
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Use "parseXXX" in "BrandingTheme"
......................................................................
core: Use "parseXXX" in "BrandingTheme"
This is needed in order to avoid the following findbugs error:
Boxing/unboxing to parse a primitive
A boxed primitive is created from a String, just to extract the
unboxed primitive value. It is more efficient to just call the static
parseXXX method.
Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING
Change-Id: I9298d8c4aee3a0ce4f9d6aa0155d5c73877b25d9
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
M backend/manager/modules/branding/src/main/java/org/ovirt/engine/core/branding/BrandingTheme.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46619
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9298d8c4aee3a0ce4f9d6aa0155d5c73877b25d9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
More information about the Engine-commits
mailing list